Fix content lock UI regression #56974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
the
[Type] Regression
|
Size Change: +394 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 3a9743a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7180552774
|
|
The Modify and Done logic are back working. The regression remaining is getting automatically to the done state when an outside block is selected. But we can merge this for now as it is better than trunk. |
jorgefilipecosta
approved these changes
Dec 12, 2023
|
Ok, let's merge this and I'll be looking to fix the last issue separately. |
ellatrix
force-pushed
the
fix/content-lock-ui
branch
from
3a9743a to
03b8537
Compare
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ok this is a bit embarrassing, but I noticed yesterday that I forgot to use the exports from #56957 and pass the isSelected prop. I asked @jorgefilipecosta how to test it and it is indeed broken.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast